Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When formatting as a timeseries, convert to many instead of wide #96

Open
iwysiu opened this issue Aug 18, 2023 · 6 comments
Open

When formatting as a timeseries, convert to many instead of wide #96

iwysiu opened this issue Aug 18, 2023 · 6 comments
Assignees

Comments

@iwysiu
Copy link
Contributor

iwysiu commented Aug 18, 2023

Currently, when we need to convert frames into the timeseries format, we covert the long format (what we get from the queries) into a wide format with the data.LongToWide function. The problem with wide format, which we currently use, is that if labels (string fields) have unique values, it creates a new column for every value. This means, that for data with n points, we end up with a n x n sized frame after converting it. Instead, we should convert to the many format, which would create n separate size 1 data frames, taking up significantly less memory.

The main part of this is that we currently use the data.LongToWide function from grafana-plugin-sdk-go and there isn't an equivalent function for LongToMany. From what I understand, the two formats should behave the same, but we should test that.

Info about formats: https://grafana.com/developers/dataplane/timeseries

issue reported in https://github.com/grafana/support-escalations/issues/6904

@iwysiu iwysiu changed the title When using the timeseries format, convert to many instead of wide When formatting as a timeseries, convert to many instead of wide Aug 18, 2023
@reagankan
Copy link

Hello team, any updates on if this will be worked on? AMG customers are reaching out for a fix. Thank you

@Brandon-Kimberly
Copy link

Bumping this again. Any updates?

@taleena
Copy link

taleena commented Sep 27, 2023

Hello, we are currently working through support coverage with AWS. This is not in place yet, but once it is we will be able to take this on.

@bhks
Copy link

bhks commented Nov 13, 2023

Hi @taleena ,

Do we have this fix worked on, customers are waiting for this issue to get fixed ?

@sidd328
Copy link

sidd328 commented Dec 22, 2023

Hi there, checking in on this issue to see if there is an update?

@iwysiu iwysiu self-assigned this Jan 4, 2024
@iwysiu
Copy link
Contributor Author

iwysiu commented Jan 9, 2024

Hi! I'm looking into implementing a fix for this, but I want to understand the use case better. Are the labels distinct for every data point? In that case, what is the use case for formatting it as a time series? It wouldn't be able to graph it as actual time series, it would just appear as a bunch of separate points. Would they be able to use it formated as a table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting
Development

No branches or pull requests

6 participants