Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable free-text searching on alert groups #2232

Closed
joeyorlando opened this issue Jun 14, 2023 · 9 comments · Fixed by #4287
Closed

re-enable free-text searching on alert groups #2232

joeyorlando opened this issue Jun 14, 2023 · 9 comments · Fixed by #4287
Labels
bug Something isn't working needs triage part:alert flow & configuration

Comments

@joeyorlando
Copy link
Contributor

#2098 and #2101 temporarily disabled it.

We should re-enable searching here, but ensure that the proper indices are added and that it works with large amounts of alert groups.
@github-actions
Copy link
Contributor

The current version of Grafana OnCall, at the time this issue was opened, is v1.2.43. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@joeyorlando joeyorlando mentioned this issue Mar 6, 2024
Closed
This was referenced Mar 26, 2024
Closed
Closed
Closed
@fantom0005
Copy link

Hello @joeyorlando @Matvey-Kuk

I hope this message finds you well. Could I kindly inquire if there is an estimated timeline for addressing the issue at hand?

It appears that the search functionality, which seems to be a fundamental feature, has been non-operational for over a year.

I was wondering if, pending the resolution of the performance issues, it might be feasible to introduce a setting that allows those who require the search function to enable it temporarily.

Thank you

@joeyorlando
Copy link
Contributor Author

this is not on the core team's short term roadmap. I provided a workaround here to have this feature enabled under a feature flag. If you're keen to open a pull request we can certainly review 🙂

@EZ4BRUCE
Copy link

this is not on the core team's short term roadmap. I provided a workaround here to have this feature enabled under a feature flag. If you're keen to open a pull request we can certainly review 🙂

thanks!

@iskhakov iskhakov mentioned this issue Apr 2, 2024
Closed
@joeyorlando joeyorlando mentioned this issue Apr 22, 2024
Closed
@fantom0005
Copy link

this is not on the core team's short term roadmap. I provided a workaround here to have this feature enabled under a feature flag. If you're keen to open a pull request we can certainly review 🙂

@joeyorlando
I tried to include a search for your suggestion in the API. Thanks, this works in the API.
But the plugin itself (frontend) pass the search field only to “stats” API and the list of Incidents are not filtered.

image

@fantom0005
Copy link

The plugin replace the entered value to null for the "search" field in this place.
https://github.com/grafana/oncall/blob/dev/grafana-plugin/src/models/alertgroup/alertgroup.ts#L62

@sreway
Copy link
Contributor

sreway commented Apr 25, 2024

@fantom0005 thanks, I renamed the search field and the search started working

@marganellim
Copy link

@sreway Can you share your solution?

@sreway sreway mentioned this issue Apr 26, 2024
Merged
3 tasks
@shev06
Copy link

shev06 commented May 15, 2024

this is not on the core team's short term roadmap. I provided a workaround here to have this feature enabled under a feature flag. If you're keen to open a pull request we can certainly review 🙂

@joeyorlando I tried to include a search for your suggestion in the API. Thanks, this works in the API. But the plugin itself (frontend) pass the search field only to “stats” API and the list of Incidents are not filtered.

image

Same issue

github-merge-queue bot pushed a commit that referenced this issue Jun 4, 2024
@sreway @joeyorlando
conditionally enable searching for alert groups via env var (#4287)
0acb66b 
# What this PR does

re-enables the search for alert groups

## Which issue(s) this PR closes

Closes #2232

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.

---------

Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage part:alert flow & configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

conditionally enable searching for alert groups via env var sreway/oncall
9 participants
@shev06 @iskhakov @Matvey-Kuk @fantom0005 @joeyorlando @sreway @EZ4BRUCE @marganellim @amurray2306