Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Msgpack int/uint interoperation problem in kafka-mdm input #910

Open
itaiin opened this issue May 14, 2018 · 2 comments
Open

Msgpack int/uint interoperation problem in kafka-mdm input #910

itaiin opened this issue May 14, 2018 · 2 comments
Milestone

Comments

@itaiin
Copy link

itaiin commented May 14, 2018

When sending metrics to MetricTank using kafka-mdm with certain msgpack clients, one may get the error

kafka-mdm decode error, skipping message. msgp: attempted to decode type "uint" with method for "int"

This is because it is common practice in many msgpack clients to use int and uint interchangeably (for example in msgpack-python positives are encoded as uint and negatives as int).

Fortunately, this issue was seems also to be fixed in newer versions of tinylib/msgp so only an update is needed.

@Dieterbe Dieterbe added this to the 0.10.0 milestone May 14, 2018
@Dieterbe
Copy link
Contributor

ok we can probably fix this by upgrading our msgp library. something for the change window of the next release

@Dieterbe Dieterbe modified the milestones: 1.0, 1.1 Aug 17, 2018
@Dieterbe
Copy link
Contributor

this will also allow us to remove this hack:
84daa62

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants