This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Fix set tags for complex targets #1948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanson7
reviewed
Nov 17, 2020
| @@ -120,7 +120,8 @@ func (a SeriesMeta) CopyWithChange(fn func(in SeriesMetaProperties) SeriesMetaPr | |||
| // SetTags fills in the Tags property with tags parsed out of s.Target | |||
| // the "name" tag is always set from s.Target, overriding any attempted override | |||
| func (s *Series) SetTags() { | |||
| numTags := strings.Count(s.Target, ";") | |||
| lastClosingParenthesis := strings.LastIndexByte(s.Target, ')') | |||
| numTags := strings.Count(s.Target[lastClosingParenthesis+1:], ";") | |||
There was a problem hiding this comment.
In the scenario where numTags >= 1 I don't believe this solution works.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a target is more complex than just containing a raw series, ie. when it contains at least one function, then
SetTagsshould consider as tags only the tag expressions (ie.;tag=value) that are found after the end of the last function of the target.Fix #1917