Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Outline Follow Up #87146

Open
gelicia opened this issue Apr 30, 2024 · 6 comments
Open

Content Outline Follow Up #87146

gelicia opened this issue Apr 30, 2024 · 6 comments

Comments

@gelicia
Copy link
Contributor

gelicia commented Apr 30, 2024

Address some UX concerns brought up in the comments for #86431

  • Discoverability with the term "Outline" "I did not know/notice that the outline was there. Also "outline" doesn't mean anything to me (spanish native speaker with english technical knowledge), and I can't link with with anything more familiar."
  • Spacing "The collapsed view is a bit tough for me. There's a lot of empty space, and I feel like it could be a bit smaller. Even in the expanded mode, I find the empty space on the left a bit unpleasant." (There is more back and forth about this in Explore: Logs in content outline #86431)

Image

  • Spacing "adding 2px more (theme.spacing(2.5)) to the left?"
  • Capitalization "capitalizing the levels"

327398864-cc96d15e-d687-4cd5-a559-360be9f617d5

  • Log level colors do not show when not selected, and in collapsed mode there is no immediate differentiation (there is a tooltip on hover)
    • @diegoadams (src): "could we keep these in a non-selected state when in their default? It appears cleaner and less cluttered. Also, given that only one filter can be applied at a time, it would make this functionality clearer to the user."
    • @matyax (src): " without colors in the collapsed version, it's hard to know what each level icon means."
@gelicia
Copy link
Contributor Author

gelicia commented May 3, 2024

Re: capitalization of the levels, I would like whatever is done to the text here to match what the legend looks like for log volume, since clicking on the filter here does the same action as clicking on the legend text in the logs volume chart. Right now both are uncapitalized. I think it would be nice if they both stayed uncapitalized, but were displayed in monospace text, to emphasize the log level existing in a log line. Note: the log level in the log itself and what the LogLevel is to grafana may not be a 1-1 match (src). This might not make sense if the label is the Grafana Log Level and not the actual log level in the log line itself. If that is the case, I would recommend no monospace but instead capitalizing both the legend and the content outline filter.

@diegoadams
Copy link

Spacing "The collapsed view is a bit tough for me. There's a lot of empty space, and I feel like it could be a bit smaller. Even in the expanded mode, I find the empty space on the left a bit unpleasant." (There is more back and forth about this in

When Amy is back from the UX offsite, I will discuss this with her. I do prefer the consistency with the MainNav as its key for the user experience in maintaining similarity.

Additionally, the dropdowns on the side are designed to potentially accommodate not just Logs but other data sources or new sections in the future.

@gelicia
Copy link
Contributor Author

gelicia commented May 7, 2024

@matyax re: collapsed log levels (src): "Brainstorming: how about displaying a single letter? E, W, I, D, U"

@diegoadams
Copy link

"Brainstorming: how about displaying a single letter? E, W, I, D, U"

@matyax, brainstorming would be a great idea, I will set something up after the current offsites. I will also bring this up with the UX team.

I'm not opposed to the "single letter icons", but from my view, if we go with it this should likely be a log-specific rule since it deviates from the standard grouping pattern used elsewhere, like how queries are typically grouped with identical icons.

Additionally, if users find the log icons confusing, they can always refer to the expanded view for more clarity and context.

Screenshot 2024-05-08 at 19 19 51

@diegoadams
Copy link

diegoadams commented May 8, 2024

@gelicia, could we update the "active states" of the mini and expanded icons and text, similar to what the mega menu does

  • Non active items = Secondary text colour
  • Active state = Primary text colour
Screenshot 2024-05-08 at 19 11 40

@gelicia
Copy link
Contributor Author

gelicia commented May 8, 2024

@gelicia, could we update the "active states" of the mini and expanded icons and text, similar to what the mega menu does

  • Non active items = Secondary text colour
  • Active state = Primary text colour

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants