Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting XY Chart when adding visualisation breaks the app #87134

Closed
Tracked by #83845
Sergej-Vlasov opened this issue Apr 30, 2024 · 5 comments · Fixed by #87161
Closed
Tracked by #83845

Selecting XY Chart when adding visualisation breaks the app #87134

Sergej-Vlasov opened this issue Apr 30, 2024 · 5 comments · Fixed by #87161
Labels
Milestone

Comments

@Sergej-Vlasov
Copy link
Contributor

Sergej-Vlasov commented Apr 30, 2024

to reproduce create new dashboard and add XY Chart

Screen.Recording.2024-04-30.at.17.02.02.mov

error in localhost
Screenshot 2024-04-30 at 16 40 52

@leeoniya
Copy link
Contributor

out of curiosity, does it break when using autoMigrateXYChartPanel feature flag as well?

@Sergej-Vlasov
Copy link
Contributor Author

Sergej-Vlasov commented Apr 30, 2024

out of curiosity, does it break when using autoMigrateXYChartPanel feature flag as well?

@leeoniya with this FF it has a silent error (but does not break the app)

Screenshot 2024-04-30 at 17 10 57

@leeoniya
Copy link
Contributor

leeoniya commented Apr 30, 2024

progress :)

that FF is a pretty big rewrite of XY. we dont have precise error messages in there yet. most likely it's missing some expected fields in the frame. hopefully by end of this week 🤞

still, this FF will be slow-rolled, since the 100% migration is not possible, so we need to be careful and hand-hold some of this.

@Sergej-Vlasov
Copy link
Contributor Author

@leeoniya just double checking if you know whether this relates more to dashboards squad or dataviz squad or both?

@leeoniya
Copy link
Contributor

leeoniya commented Apr 30, 2024

i think it's a difference with scenes.

XYChart (without FF) uses a custom editor, which previously only received series DataFrames, but now receives annotations type frames. you can see the difference by putting breakpoints into AutoEditor and load a new dashboard on https://testymctestface.grafana-dev.net/ with and without &scenes=false.

normal load (with scenes enabled):

image

with &scenes=false:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🚀 Done
Development

Successfully merging a pull request may close this issue.

4 participants