DashboardScene: adjust lib panel as a dashboard datasource refresh logic #87120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergej-Vlasov
added
type/bug
area/frontend/library-panels
no-changelog
mdvictor
reviewed
Apr 30, 2024
| @@ -10,10 +10,15 @@ export class PanelModelCompatibilityWrapper implements PanelModel { | |||
| constructor(private _vizPanel: VizPanel) {} | |||
|
|
|||
| public get id() { | |||
| // console.log('this._vizPanel.parent', this._vizPanel.parent); | |||
| // console.log('this._vizPanel', this._vizPanel); | |||
|
|
|||
| const id = getPanelIdForVizPanel( | |||
There was a problem hiding this comment.
I think we should use getPanelIdForLibraryVizPanel instead of modifying getPanelIdForVizPanel here. So I think we can check if the vizPanel parent is LibraryVizPanel or not and call the appropriate function for it.
torkelo
reviewed
Apr 30, 2024
Comment on lines
33
to
37
| // return parseInt(panel.state.key!.replace('panel-', ''), 10); | ||
|
|
||
| let key = ('panelKey' in panel.state ? panel.state.panelKey : panel.state.key) as string; | ||
|
|
||
| return parseInt(key.replace('panel-', ''), 10); |
There was a problem hiding this comment.
I think #87125 is enough / simpler fix
Sergej-Vlasov
changed the title
torkelo
reviewed
Apr 30, 2024
Comment on lines
60
to
62
| if (!panel.parent.isActive) { | ||
| panel.parent.activate(); | ||
| } |
There was a problem hiding this comment.
need to call the deactivation function returned by activate (in the deactivation function for this behavior)
Sergej-Vlasov
added
the
backport v11.0.x
|
This PR must be merged before a backport PR will be created. |
ivanortegaalba
approved these changes
May 2, 2024
|
Tested and the problem is solved 💯 |
Sergej-Vlasov
added a commit
that referenced
this pull request
May 2, 2024
…refresh logic (#87232) DashboardScene: adjust lib panel as a dashboard datasource refresh logic (#87120) * activate library viz panel and adjust id extractor * revert parts that are fixed in #87125 * clean up after activation handler (cherry picked from commit afbd02c) Co-authored-by: Sergej-Vlasov <37613182+Sergej-Vlasov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is not caused by a more global issue.
So far seems like two issues were causing the bug:
panel id was not extracted correctly -fixed in DashboardScene: Fixes issue referring to library panel in dashboard data source #87125panel.state.keyinLibraryVizPanelwas uuid andpanelKeywas the correct propertydashboard-scene/scene/DashboardDatasourceBehaviour.tsxFixes #87128
Special notes for your reviewer:
Please check that: