add 3 icons so they show in storybook #87123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
reviewed
Apr 30, 2024
| @@ -55,11 +55,13 @@ | |||
| "unicons/dashboard", | |||
| "unicons/database", | |||
| "unicons/document-info", | |||
| "unicons/document-layout-left", | |||
There was a problem hiding this comment.
This shouldn't be necessary, these icons are already available, you can see them in the latest Storybook.
There was a problem hiding this comment.
...yeah, weird. I would have sworn that I ran storybook locally first, confirmed the icons weren't showing (as they don't show up in the official storybook), then made the change & confirmed they now showed up...
I think I must have tricked myself, though; I tried breaking it again locally, but can't.
Closing PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #87118
But I'm not sure if this is wise or complete; one of the FE engineers needs to verify.
@natydej requested that someone add these 3 icons, following the steps here but I checked, and someone had already added the icons and the entries in the map file.
Other icons seem to also be listed in cached.json, and when I added these 3 there as well, now they appear in storybook when I run it locally.
Soneone should decide what the correct steps should be and update the Readme before merging this fix. 馃檹