Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrafanaUI: Add three icons "enter", "paragraph" and "document-layout-left" #87118

Closed
3 tasks
natydej opened this issue Apr 30, 2024 · 7 comments
Closed
3 tasks
Labels
area/grafana/ui Issues that belong to components in the @grafana/ui library

Comments

@natydej
Copy link

natydej commented Apr 30, 2024

What is this feature?:
Add three icons to our Grafana UI library from IconScout: enter, paragraph and document-layout-left
for more see slack thread

Where is/could it be used?:
For Grafana LLM feature for title and description generation is being used:
Screenshot 2024-04-30 at 11 56 58

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
@natydej natydej added the area/grafana/ui Issues that belong to components in the @grafana/ui library label Apr 30, 2024
@jtheory
Copy link
Contributor

jtheory commented Apr 30, 2024

It looks like this is already working (before my attempted fix); but our latest storybook must not actually be showing latest code.

@natydej
Copy link
Author

natydej commented Apr 30, 2024

And do you know where is the latest version of our Storybook? Thanks for taking a look at this.

@jtheory
Copy link
Contributor

jtheory commented May 2, 2024

The one I linked in my comment ^ is the one bookmarked in the saga-design-system Slack channel -- worth double-checking with them if 1) the bookmark is still right or 2) if they don't yet have a process to keep it updated

@natydej
Copy link
Author

natydej commented May 3, 2024

As Rob said above ^ This is already in our code but is not updated in our storybook.

@natydej natydej closed this as completed May 3, 2024
@natydej
Copy link
Author

natydej commented May 3, 2024

cc @JoaoSilvaGrafana @Clarity-89 to double-check with you about this storybook link, if yes, is there a reason why this is not updated with the icons that we are talking about here?

@Clarity-89
Copy link
Contributor

@natydej the latest storybook is updated only when a new Grafana version is released. To get a more up-to-date version of Storybook, you can use the canary version.

@natydej
Copy link
Author

natydej commented May 3, 2024

Ohh got it! thanks so much for the clarification @Clarity-89 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grafana/ui Issues that belong to components in the @grafana/ui library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants