Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider configuring failIfNotFullyCacheable to true by default in the composite workflows #596

Open
erichaagdev opened this issue Apr 10, 2024 · 0 comments

Comments

@erichaagdev
Copy link
Member

failIfNotFullyCacheable: true should be the default behavior and failIfNotFullyCacheable: false should be the exception.

If a user forgets to configure failIfNotFullyCacheable: true they will have a false sense of security thinking their build is optimized when it may not be.

This would be a breaking change, but only if failIfNotFullyCacheable is not already configured and the user's build has cache misses. It's reasonable to assume those cases are a misconfiguration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant