Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a plain text console mode for environments that do not render ASNI escape codes #546

Open
clayburn opened this issue Dec 20, 2023 · 2 comments

Comments

@clayburn
Copy link
Member

The Build Validation Scripts utilize ANSI escape codes in the summary section in order to render text with color in terminals that support it. While this is visually pleasant and a reasonable default, not every environment attempts to render color when these codes are encountered. Instead, they are printed as plain text, leading to visual clutter. Notably, Jenkins console logs do not support these escape codes (without plugin support):

Screenshot 2023-12-20 at 7 46 46 AM

To solve this, it would be nice if there were a way to disable these escape codes and just print the plain text output.

@jthurne
Copy link
Member

jthurne commented Dec 20, 2023

@erichaagdev I think this could be easily achieved by adding a CLI argument, that when set, causes the color code constants to be set to empty strings.

@erichaagdev
Copy link
Member

We could also switch to plain text mode when running with the fail if not fully cacheable flag as the main use case there is for running in CI. Unfortunately, that wouldn't for experiment 1 since it doesn't have that flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants