Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts do not wait long enough for results when running with --fail-if-not-fully-cacheable #505

Open
erichaagdev opened this issue Sep 18, 2023 · 0 comments

Comments

@erichaagdev
Copy link
Member

The availabilityWaitTimeoutSecs of the API is always configured to be 10 seconds with no way to override it. After this 10 seconds, if there is still no build scan data available, the scripts will proceed without the performance characteristics populated. In most cases this is fine because you can use the corresponding build scan quick links to investigate.

However, having the API call succeed and the corresponding build data to be available to the scripts is critical when running with --fail-if-no-fully-cacheable. I propose we increase availabilityWaitTimeoutSecs when running with --fail-if-not-fully-cacheable (e.g. 30s, 60s, 120s).

This is related to but does not replace #493. This will ensure we get a response in more cases while #493 will fail the build if no response is received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant