Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gradle-home-cache-cleanup: true the default #26

Open
martinbonnin opened this issue Mar 17, 2023 · 2 comments
Open

Make gradle-home-cache-cleanup: true the default #26

martinbonnin opened this issue Mar 17, 2023 · 2 comments
Labels
enhancement New feature or request in:cache-cleanup

Comments

@martinbonnin
Copy link

Hi 馃憢 Thanks for saving our build times 鉂わ笍 Would it make sense to include gradle-home-cache-cleanup: true by default and have the option opt-out? Sounds like this would be a reasonable default to expect?
@martinbonnin martinbonnin mentioned this issue Mar 17, 2023
Merged
@ashdavies ashdavies mentioned this issue Mar 17, 2023
Merged
@bigdaz
Copy link
Member

bigdaz commented Mar 27, 2023

@martinbonnin Yes this is the plan longer term, but the cache-cleanup was released as "experimental" and I didn't feel ready to enable it by default. Enabling by default will be in an upcoming release.

@bigdaz bigdaz added the enhancement New feature or request label Mar 27, 2023
sschuberth referenced this issue in oss-review-toolkit/ort Jun 22, 2023
@sschuberth
ci(GitHub): Clean up the Gradle user home before caching
0c8b3d2 
See [1]. At a later point, this will become the default [2], and then
this could be reverted.

[1]: https://github.com/gradle/gradle-build-action#removing-unused-files-from-gradle-user-home-before-saving-to-cache
[2]: https://github.com/gradle/gradle-build-action/issues/630

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth sschuberth mentioned this issue Jun 22, 2023
Merged
sschuberth referenced this issue in oss-review-toolkit/ort Jun 22, 2023
@sschuberth
ci(GitHub): Clean up the Gradle user home before caching
4fbcd31 
See [1]. At a later point, this will become the default [2], and then
this could be reverted.

[1]: https://github.com/gradle/gradle-build-action#removing-unused-files-from-gradle-user-home-before-saving-to-cache
[2]: https://github.com/gradle/gradle-build-action/issues/630

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@bigdaz
Copy link
Member

bigdaz commented Aug 21, 2023 •
edited

Here are the current issues that need to be investigated/fixed prior to enabling gradle-home-cache-cleanup by default:

@bigdaz bigdaz transferred this issue from gradle/gradle-build-action Feb 9, 2024
@bigdaz bigdaz mentioned this issue Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request in:cache-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bigdaz @martinbonnin