Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or update existing PR comments when adding a new one #176

Open
gabrielfeo opened this issue Apr 17, 2024 · 1 comment
Open

Remove or update existing PR comments when adding a new one #176

gabrielfeo opened this issue Apr 17, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers in:setup-gradle

Comments

@gabrielfeo
Copy link
Contributor

Given I set add-job-summary-as-pr-comment: 'on-failure',
And 'foo' job has failed leaving a PR comment with the failure
When a later run of 'foo' succeeds

Then should the failure comment be removed? From what I gathered, that's not implemented, so I'm opening a discussion about it. Repro of current behavior: gabrielfeo/develocity-api-kotlin#233

In my opinion, it'd be best to either remove the comment or update it with an OK sign and the latest (successful) build scan. When the job succeeds, the failure comment becomes outdated info.

@bigdaz bigdaz changed the title Should successful runs remove past on-failure comments? Remove or update existing PR comments when adding a new one Apr 17, 2024
@bigdaz
Copy link
Member

bigdaz commented Apr 17, 2024

You're right we don't do anything to remove or modify previous job summary comments when submitting a new one.
Likely the ideal default behaviour would be to replace any outdated PR comments with a simple link to the GitHub Actions build (removing the large summary). Although removing it would also be reasonable behaviour I guess.

@bigdaz bigdaz added enhancement New feature or request in:setup-gradle good first issue Good for newcomers labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers in:setup-gradle
Projects
None yet
Development

No branches or pull requests

2 participants