Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request: (sindresorhus/awesome) or (qinwf/awesome-R) #9

Open
3 of 5 tasks
grabear opened this issue Aug 18, 2017 · 10 comments
Open
3 of 5 tasks

Pull Request: (sindresorhus/awesome) or (qinwf/awesome-R) #9

grabear opened this issue Aug 18, 2017 · 10 comments

Comments

@grabear
Copy link
Owner

grabear commented Aug 18, 2017

Where should we put the awesome-rshiny list? @sdhutchins @daattali @dpastoor @ramnathv @ucg8j

@ucg8j
Copy link
Collaborator

ucg8j commented Sep 26, 2017

My vote would be

  • Under Front-End Development?
    This may help increase awareness outside of the R community.
  • As a sub bullet under the R programming language?
    Not sure what you are referring to, sounds good! Could you please provide a link to clarify?
  • Merge with awesome-R
    No, I think shiny is big enough to warrant it's own awesomeness. I had a quick look at awesome-python... and the awesome-flask and awesome-django. They each have their own.
  • Or add a link to awesome-R
    That would definitely be helpful. Happy to help out with PRs if the group decides this way. It's also what awesome-python does.
  • Or should we do something completely different?
    I'll let the more imaginative come up with other suggestions!

@grabear
Copy link
Owner Author

grabear commented Sep 27, 2017

Ok good deal! @ucg8j This might make it clearer.

So we could do one of the first options and one of the second options.

@ucg8j
Copy link
Collaborator

ucg8j commented Sep 27, 2017

Cool! I've just submitted a pull request on awesome-R. There's quite a lot of open PRs so that might take a while. It looks like @sdhutchins PR has been accepted.

Ah, I think it just clicked as to what you meant. Add on this awesome list, a link to the awesome-R page?

@grabear
Copy link
Owner Author

grabear commented Sep 27, 2017

Not exactly. Sorry I can see how that was confusing. What I meant by 'Merge with Awesome-R' was to basically add an r-Shiny section to their list. So we copy and paste all of our README.md into their README.md. But I don't think that will be useful after all. @ucg8j

@grabear
Copy link
Owner Author

grabear commented Sep 27, 2017

Got another PR going. @ucg8j @sdhutchins @daattali @dpastoor @jcheng5

@sdhutchins
Copy link
Collaborator

sdhutchins commented Sep 27, 2017

Everything looks awesome and uh err shiny @ucg8j @grabear

@grabear
Copy link
Owner Author

grabear commented Oct 12, 2017

So @ucg8j's PR went through on Awesome-R!
Cheers! @sdhutchins @dpastoor

@sdhutchins
Copy link
Collaborator

Can we go ahead and close this out? @grabear

@grabear
Copy link
Owner Author

grabear commented Mar 19, 2018

Not yet. The other PR is still open. I'll look at the guidelines for the main awesome list to make sure we comply.

@sdhutchins
Copy link
Collaborator

Didn't even realize it was still open. Hmmm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants