Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High severity CVE related with go stdlib version #903

Closed
ikheifets-splunk opened this issue May 9, 2024 · 13 comments · Fixed by #905
Closed

High severity CVE related with go stdlib version #903

ikheifets-splunk opened this issue May 9, 2024 · 13 comments · Fixed by #905
Labels

Comments

@ikheifets-splunk
Copy link

ikheifets-splunk commented May 9, 2024

Describe the bug
High severity CVE
Screenshot 2024-05-09 at 13 35 42

How To Reproduce
https://github.com/aquasecurity/trivy detected this CVE

Expected Behavior
using Go version without CVE

Actual Behavior
using Go version with CVE

Environment:

  • Version of goss 0.4.6
  • OS/Distribution version: alpine linux 3.19
@ikheifets-splunk ikheifets-splunk changed the title High severity CVE related with go version High severity CVE related with go stdlib version May 9, 2024
aelsabbahy added a commit that referenced this issue May 10, 2024
Update github.com/onsi/gomega to fix golang.org/x/net security finding
closes #894

CI should use newer version of go which closes #903
@ikheifets-splunk
Copy link
Author

Hello, @aelsabbahy !
Thank you for PR. When you planning to release it? It would available on 0.4.7?

@aelsabbahy
Copy link
Member

Reopening issue until the release happens. Yes, this will be part of the next goss release.

I should look into automating the trivy checks. 🤔

@aelsabbahy
Copy link
Member

Released 0.4.7 which should fix this. Feel free to re-open ticket if it doesn't resolve this finding.

@ikheifets-splunk
Copy link
Author

Many thanks @aelsabbahy ! Will test it :)

@ikheifets-splunk
Copy link
Author

Checked, it's passing CVE testing, closing this issue :) thanks @aelsabbahy

@aelsabbahy
Copy link
Member

aelsabbahy commented May 16, 2024

Thanks for reporting. If you don't mind.. can you show me how to reproduce the failing result on the old version? This way I can look into automating this at a future time.

@ikheifets-splunk
Copy link
Author

ikheifets-splunk commented May 16, 2024

Sure, we using Trivy GitHub action on CI which testing our docker image (our open source project is docker image), results you can see here. After update goss version on 0.4.7 CI became green

we just added few lines of code on our CI

@ikheifets-splunk
Copy link
Author

ikheifets-splunk commented May 16, 2024

@aelsabbahy I think you can use such command: trivy repo --tag v0.4.6 https://github.com/goss-org/goss

P.S. docs here

@aelsabbahy
Copy link
Member

Perfect, yeah that worked, thanks! Will check out the github actions too.

I tried trivy fs goss-binary and got no results earlier, figured I was doing something wrong.

@ikheifets-splunk
Copy link
Author

I also will try yet another time restart this step on CI, they updating CVE database every day, existing small chance that they can reclassify CVE.

We had last release 3 days ago probably something changed in their db during this time

@aelsabbahy
Copy link
Member

Oh, I just meant it doesn't detect it if you scan the binary directory but does if you scan the repo.

I was confused earlier since I couldn't reproduce your results (due to scanning binary), scanning repo works just fine and I might set up a weekly scan.

Thanks again, this should improve the security posture of Goss!

@dklimpel
Copy link
Contributor

The scan with trivy GitHub action of goss docker file I had also added to:

@aelsabbahy
Copy link
Member

Awesome, thanks for all the clarifications, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants