New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[db/v1/instances] missed access field - trove database dbaas #2878

Open

zhekazuev opened this issue Jan 22, 2024 · 0 comments · May be fixed by #2876

Contributor

zhekazuev commented Jan 22, 2024 •

edited

Description

I have identified a missing field/fields in DB V1:

access
access.is_public
access.allowed_cidrs

Expected Behavior

The access field with subfields should be present in DB V1.

Proposed Solution

I propose to add missing fields to DB V1.

Additional Information

API Docs: https://docs.openstack.org/api-ref/database/#create-database-instance
Service/
‎InstanceController.create: https://github.com/openstack/trove/blob/40fdb7b44fb33e022b77ba8df63fde2565c70dea/trove/instance/service.py#L366
Service/models.Instance.create: https://github.com/openstack/trove/blob/40fdb7b44fb33e022b77ba8df63fde2565c70dea/trove/instance/service.py#L494
Service/
‎InstanceController.update: https://github.com/openstack/trove/blob/40fdb7b44fb33e022b77ba8df63fde2565c70dea/trove/instance/service.py#L581

Related links:

The text was updated successfully, but these errors were encountered:

zhekazuev linked a pull request

that will close this issue

[db/v1/instances] add access field - trove database dbaas #2876

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment