-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New recipient syncing removes all other public keys #2620
Comments
How did you install that store? I think you might need to import the old public keys first using:
|
I used |
That's surprising. I could reproduce locally, adding a substore using:
seems to work fine, but doing the same thing using
|
Trying to introduce |
And now we had the same thing happen as OP. Upon their first sync, a colleague's gopass removed all public keys but their own and immediately pushed that change to the remote. 😔 |
Sorry for that. I hope that I can take a look at this soon. |
Can anyone that is affected re-run the steps to reproduce with I think there might be a mismatch between how recipients are specified in the |
The cleanup during import is currently buggy on some scenarios so as a workaround we'll disable auto-cleanup by default and introduce `recipients.remove-extra-keys` to allow users to turn it back on. See gopasspwGH-2620 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
The cleanup during import is currently buggy on some scenarios so as a workaround we'll disable auto-cleanup by default and introduce `recipients.remove-extra-keys` to allow users to turn it back on. See GH-2620 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
We observed this problem as well, but only with our newest team member. The only difference we came across was that she was the only team member initializing the password store with
We tried simulating this for her by moving her root store into the legacy location and removing all other stuff created by
When we tried again, |
Thank you @jonmz . This is useful feedback. I will try to reproduce this as well. |
Summary
I added myself as a new recipient to a store on a new machine. After running gopass clone and sync I'm able to see the stored secrets, but syncing removed all other public keys from the store. Syncing shows the following output
Steps To Reproduce
Sync an existing store using a new recipient.
Expected behavior
Syncing would import the existing public keys to the new recipients machine instead of removing them from the store.
Environment
The text was updated successfully, but these errors were encountered: