Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: no hardcoded username in password-store path #2587

Open
markfaine opened this issue May 4, 2023 · 3 comments
Open

Feature Request: no hardcoded username in password-store path #2587

markfaine opened this issue May 4, 2023 · 3 comments
Labels
bug Defects
Milestone

Comments

@markfaine
Copy link

Summary

Please write the path to the config without hard-coding the username
Instead of

[mounts]
        path = /home/mfaine/.password-store

Write it like:

[mounts]
        path = ~/.password-store
@dominikschulz dominikschulz added the bug Defects label May 5, 2023
@dominikschulz dominikschulz added this to the 1.x.x milestone May 5, 2023
@kanielrkirby
Copy link

@dominikschulz I would like to try my hand at making this change, if possible.

One of the questions I had, is there ever a use-case in which you'd mount somewhere outside a user's directory? Currently trying to get an idea of the scope of this change. I know there's going to be different paths depending on the OS and use.

@AnomalRoil
Copy link
Member

I guess the trickiest issue with this is cross-compatibility with Windows. But please, we're happy to review a PR if you want to try and do it :D

@kanielrkirby
Copy link

@AnomalRoil So I've been looking at it, it doesn't look too hard to make it consistent across different OSs, Go comes with built-in packages (os/user and path/filepath) that make that a lot easier.

I would like to ask for a little advice. Where do you think this logic will need to be put in place? With ~3 levels of functions for both init and mount, along with some extra logic for checking for duplicates, I suppose that's where I'm struggling a bit to get a solid idea.

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects
Projects
None yet
Development

No branches or pull requests

4 participants