Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GvhProjectSettings.xml changes/resets itself #524

Closed
ManuelRauber opened this issue Jun 12, 2022 · 113 comments · Fixed by #678 or #688
Closed

[Bug] GvhProjectSettings.xml changes/resets itself #524

ManuelRauber opened this issue Jun 12, 2022 · 113 comments · Fixed by #678 or #688

Comments

@ManuelRauber
Copy link

[REQUIRED] Please fill in the following fields:

  • Unity editor version: 2021.3.4f1
  • External Dependency Manager version: 1.2.171
  • Source you installed EDM4U: .unitypackage
  • Features in External Dependency Manager in use: Android Resolver
  • Platform you are using the Unity editor on: Mac

[REQUIRED] Please describe the issue here:

Sometimes, not really reproducible, the file GvhProjectSettings.xml changes/resets itself. This is super annoying, because the file pops up in the git stage:

image

As well as this dialogs pops up all the time

image

And as you can see from the diff file above, the settings get reset, e.g. I've disabled both auto-resolution on build and in editor and it will reset back to true, because that's the default.

I currently can not reproduce it exactly, when it happens. Sometimes it does not happen all day, sometimes it happens multiple times day.

@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@paulinon paulinon added needs-attention Need Googler's attention and removed new to be triaged labels Jun 13, 2022
@paulinon
Copy link
Collaborator

Hi @ManuelRauber,

Could you provide the steps you've performed before facing this issue so that we can identify what's causing this behavior?

@paulinon paulinon added needs-info Need information for the developer and removed needs-attention Need Googler's attention labels Jun 14, 2022
@faveris
Copy link

faveris commented Jun 18, 2022

I have the same issue. I've just installed External Dependency Manager with one of SDKs and these things start to happen. Looks like it happens after recompilation but not after each one. Also sometimes after exiting playmode.

Unity editor version: 2021.3.3f1
External Dependency Manager version: 1.2.169
Source you installed EDM4U: .unitypackage
Features in External Dependency Manager in use: Android Resolver
Platform you are using the Unity editor on: Mac

@ghost
Copy link

ghost commented Jun 20, 2022

We are facing same issue on
Unity: 2021.3.4f1
Editor: Mac (Silicon)

@ManuelRauber
Copy link
Author

Hi @ManuelRauber,

Could you provide the steps you've performed before facing this issue so that we can identify what's causing this behavior?

Unfortunately, I can not answer this, because I simply use the Unity Editor.
Sometimes I just open it and then I see a change in git and the file has been written as shown in the first post.

Sometimes that does not happen, I have no clear way to reproduce this behavior.

Currently, I'm carefully looking whenever this change happens, but I've not found a clear way yet.

@google-oss-bot google-oss-bot added needs-attention Need Googler's attention and removed needs-info Need information for the developer labels Jun 20, 2022
@belike81
Copy link

Having the exact same issue. Reset happens every few minutes.
Makes it very, very difficult to not accidentally commit the changed file (which breaks the build).

Unity: 2021.3.4f1
Editor: Mac (Silicon)
External Dependency Manager version: 1.2.170
Source you installed EDM4U: .unitypackage
Features in External Dependency Manager in use: iOS Resolver
Platform you are using the Unity editor on: Mac

@paulinon
Copy link
Collaborator

Hi folks,

Does disabling auto-resolution prevent this issue from happening? The Android Resolver automatically keeps track of the differentdependencies you have specified in your Unity project. The resolution process runs when the specified dependencies are not present in your project.

@paulinon paulinon added needs-info Need information for the developer and removed needs-attention Need Googler's attention labels Jun 21, 2022
@faveris
Copy link

faveris commented Jun 21, 2022

Does disabling auto-resolution prevent this issue from happening?

For me issue is happening with auto-resolution turned off

@belike81
Copy link

Does disabling auto-resolution prevent this issue from happening?

Same as above - it's turned off, but the issue is still occurring. Judging by all the reports seems to be mac specific.

@google-oss-bot google-oss-bot added the stale Don't have recent activity label Jun 29, 2022
@google-oss-bot
Copy link

Hey @ManuelRauber. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

@ManuelRauber
Copy link
Author

Hey @ManuelRauber. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

Well, Google Bot, we can not add more information, because we don't have more information.

I still have no way that I do to reproduce it.

It just popped up after updating a Unity Package via Package Manager. To test, I reverted the changes in git and updated the unity package again. This time, the GvhProjectSettings.xml did not change. No clue, sorry.

I'd love to help to investigate the issue, but since I can not cleary reproduce it, it's hard to track.

@google-oss-bot google-oss-bot added needs-attention Need Googler's attention and removed needs-info Need information for the developer stale Don't have recent activity labels Jun 29, 2022
@paulinon
Copy link
Collaborator

Thanks for the update, folks. I'll bring this up with the team so that we can analyze this behavior. In the meantime, could you try our latest version of the resolver (1.2.172) to make sure the issue persists?

@paulinon paulinon removed needs-attention Need Googler's attention labels Jun 30, 2022
@harlan
Copy link

harlan commented Oct 26, 2023

@AliAlbarrak i appreciate the work you're putting into this.

@toxikman
Copy link

Here is the new, hopefully working, release

@AliAlbarrak Thanks, I tried this out (Unity 2022.2.11 on MacOS). It seemed to help at first, but unfortunately I'm still getting phantom changes to GvhProjectSettings.xml with Unity on Standalone platform.

@AliAlbarrak I also got the problem again with your previous release. I'm going to try the latest one you posted most recently that creates tmp files.

@MigrantP
Copy link

Since the most recent update from @AliAlbarrak we haven't seen the problem again!

@AliAlbarrak
Copy link

Your feedback is much appreciated.

Due to the nature of this bug, it is difficult to prove a fix, or claim that a change fixes it.

I'll wait few days before making the pull request to allow for more testing

@toxikman
Copy link

I can report that we've been using this new version for a few days and so far no issues with the XML getting reset! The temporary file solution seems to solve the issue. Note that we have not tested changing any of the settings, so you should rely on others to verify that the XML file is being written correctly when it needs to be.

@MigrantP
Copy link

An update after a few weeks - the issue has occurred again. However it happens way less often for sure, so at least it's quite an improvement!

@AliAlbarrak
Copy link

@MigrantP thanks for your feedback
I'll close the pull request since it is not a definite fix. I'll look for better solutions but I'm busy now. I might get back to this early December

@Tommigun1980
Copy link

Tommigun1980 commented Nov 18, 2023

@paulinon Hi. When will this be fixed? This might be one of the most time consuming and annoying bugs ever. It is unfathomable that it's not been fixed yet.

Can we pool a monetary bounty to Google to get it fixed?

@v17alya
Copy link

v17alya commented Nov 18, 2023

It's horrible. When will this be fixed? 🥲😭

@Tommigun1980
Copy link

Hi @paulinon. Any progress on this one? It's so incredibly risky to have the file auto reset it all the time by accidental commits, not to mention how infuriating it is to close the resolver dialog 50 times a day.

This will drive people away from Firebase and other services Google is providing that are dependent on the resolver.

@toxikman
Copy link

toxikman commented Dec 15, 2023

@Tommigun1980 The "temporary file solution" that @AliAlbarrak posted on Oct 25 does work for us, have you tried it?

@AliAlbarrak
Copy link

Sorry for long delay since last update.
Here is new attempt. This time I'm avoiding overriding the file when settings didn't change. Previously, even when settings are the same, the file gets written 3 times with every domain reload. I added an extra check to skip file write if settings didn't change since last read.

I'm opening the pull request again as well.

Again, your feedback is appreciated.

@mhctseu
Copy link

mhctseu commented Dec 26, 2023

Sorry for long delay since last update. Here is new attempt. This time I'm avoiding overriding the file when settings didn't change. Previously, even when settings are the same, the file gets written 3 times with every domain reload. I added an extra check to skip file write if settings didn't change since last read.

I'm opening the pull request again as well.

Again, your feedback is appreciated.

@AliAlbarrak Salute!

Feel so sad that the team ignored your work and no feedback at all.

@Ned11
Copy link

Ned11 commented Dec 27, 2023

This issue is observed in 1.2.177 and 1.2.178. I am surprised that there's no official fix for an issue that started two years ago.

@RocksteadyDog
Copy link

I tried version 1.2.180 and so far everything is great!)

@Tommigun1980
Copy link

Tommigun1980 commented Jan 17, 2024

@AliAlbarrak Thanks so much for the pull request. I tried your version but unfortunately there's still some issues. In my setup I have copied the .tgz file to the packages folder and selected "install from package" (so the manifest points to the local package path and the .tgz file is committed to source control).

The issues are as follows:

  • Every time the project is opened the resolver still pops up. Expected behaviour is that it shouldn't pop up once the user has entered settings. I stopped testing after this so don't know how frequent the popups would be.
  • The project seems to take longer to open, it stalls at the final progress bar at either "invoking project callbacks" or "opening project". I am not 100% sure about this and didn't conduct any further testing.

If you have time to fix these issues, or if anyone else could build on the pull request that would be great, as I'm worried the pull request will otherwise be rejected as it doesn't fully solve the issue.

Thanks so much again for your tremendous effort, I appreciate it a lot!

@Tommigun1980
Copy link

Tommigun1980 commented Jan 17, 2024

@paulinon Please can't anyone from Google support us? The resolver has been quite broken for years and we are really scrambling to make this work. At this point any support for your software would be appreciated and would be in your interest as well, as the resolver makes sure software is released on Android platforms as well. Thank you.

@AliAlbarrak
Copy link

@Tommigun1980 Thanks for your report.
My team use a similar deployment (using .tgz file) but I couldn't reproduce your issues. It is understandable since this bug is very inconsistent but if you can provide more info about how to reproduce your issues, or a minimal sample project, I'll gladly try to fix them

@Tommigun1980
Copy link

Tommigun1980 commented Jan 28, 2024

@Tommigun1980 Thanks for your report. My team use a similar deployment (using .tgz file) but I couldn't reproduce your issues. It is understandable since this bug is very inconsistent but if you can provide more info about how to reproduce your issues, or a minimal sample project, I'll gladly try to fix them

Hi and thanks again for your effort with the patch. I don't have repro steps other than opening the project and the resolver pops up. Don't think I saw any difference vs the official version fwiw. I am using an Intel MacBook Pro (2019), macOS Ventura and Unity 2022.3.15.

@berniegp
Copy link
Contributor

New fix attempt in #678 with an analysis of why this issue happens.
Binaries here https://github.com/berniegp/unity-jar-resolver/releases/tag/v1.2.179 for those who want to try it out.

@harlan
Copy link

harlan commented Apr 13, 2024

What are the steps to try to get @berniegp 's #678 tested/merged etc?

@berniegp
Copy link
Contributor

Update: 1 month in at my org we're not seeing setting file corruption anymore on Windows and MacOS.

@jonsenson-uken
Copy link

Just a heads up, we tried @berniegp's fix recently and the binaries provided ended up breaking our iOS builds on Jenkins. We're currently on Unity 2022.3.22 and XCode 15.0.1 and for some reason using these updated binaries causes the resolver to never apply its postbuild processing and the Podfile is never generated which broke our Firebase dependency.

Not entirely sure what the issue was since I see no obvious errors in the logs. It just seemed to ignore the settings file and never generate the Podfile. Reverting only the iOSResolver.dll to the non-patched version fixes the issue so we're hoping that doing only that will fix the settings file being reset in editor while allowing builds to complete.

@a-maurice
Copy link
Collaborator

I've done a release with the fix, version 1.2.180. @jonsenson-uken I'm not sure what the issue you saw could be, I tried a couple different Unity versions to test, and it seemed good on my end. But if you are still having issues, please open a new issue ticket about it, along with anything that might help ping down a problem.

@CodeMasterYi
Copy link

Wow! Finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet