Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity version not mentioned; changes required for 2019.4 LTS support #6

Closed
hybridherbst opened this issue Jun 26, 2020 · 4 comments
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@hybridherbst
Copy link

Current Unity version is 2018.4 LTS.

For 2019.4 LTS, the following packages need to be added:

  • com.unity.xr.legacyinputhelpers
  • com.unity.multiplayer-hlapi
@kidavid
Copy link
Contributor

kidavid commented Jun 26, 2020

Thank you for the tip, @hybridherbst !
We will consider this change in our next update.

@kidavid kidavid closed this as completed Jun 26, 2020
@hybridherbst
Copy link
Author

hybridherbst commented Jun 26, 2020

Thanks!
One note: common usage of GitHub would be to leave Issues open until they are fixed to avoid other people reporting the same issues... This also allows other users to see issues that are still open when they try to get something to work.

@kidavid kidavid reopened this Jun 26, 2020
@ruofeidu
Copy link
Collaborator

ruofeidu commented Jun 30, 2020

Thank you @hybridherbst for your feedback. We have added the following pointers to README.md.

These samples target Unity 2018.4.16f1 and require ARCore SDK for Unity v1.18.0 or newer.

@ruofeidu ruofeidu self-assigned this Jun 30, 2020
@ruofeidu ruofeidu pinned this issue Jun 30, 2020
@hybridherbst
Copy link
Author

I think the point of this issue here was to also help other people use it on 2019.4. Why not add the information as well - you can point out that only 2018 is officially supported if that's the concern here.
I can tell you that it works fine on 2019 though :)

@ruofeidu ruofeidu added the documentation Improvements or additions to documentation label Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants