Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add solution_channel parameter to API loader #961

Open
wangela opened this issue Nov 23, 2021 · 0 comments
Open

feat: add solution_channel parameter to API loader #961

wangela opened this issue Nov 23, 2021 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wangela
Copy link
Member

wangela commented Nov 23, 2021

There is a new parameter in Maps Platform JS and WS APIs [solution_channel](https://developers.google.com/maps/documentation/javascript/url-params#optional_parameters).

The generator(s) in /shared could be updated to take an optional value for a property solution_channel and append it to the loader URL in the same way that callback and version are supported in the /samples/store-locator/package.json file. I think /shared/layout.njk L63 is where these parameters are loaded and the support for the new parameter needs to be added.

@wangela wangela added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. labels Nov 23, 2021
@jpoehnelt jpoehnelt assigned wangela and unassigned jpoehnelt Dec 30, 2021
@wangela wangela added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants