Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarkerClusterer: unnecessary rerendering of clusters when nothing has changed #801

Open
ixam1 opened this issue Nov 17, 2023 · 1 comment · May be fixed by #802
Open

MarkerClusterer: unnecessary rerendering of clusters when nothing has changed #801

ixam1 opened this issue Nov 17, 2023 · 1 comment · May be fixed by #802
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ixam1
Copy link

ixam1 commented Nov 17, 2023

Steps to reproduce

  1. use MarkerClusterer
  2. Optional: use vector maps with fractional zoom and animated cluster markers to see the effect even more
  3. clusters get rerendered when zooming even when they havent changed, this causes minor flickering for default maps, but really bad experience if you use fractional zoom vector maps and animated clusters

Video examples

Video example with vector maps, fractional zoom and animated clusters (lots of unnecessary rerendering and animating)

Screen.Recording.2023-11-17.at.10.24.32.mov

Video example with vector maps, fractional zoom and non-animated clusters (flickering)

fractional.no.animation.not.fixed.mov

Video example without fractional zoom and animated clusters (sometimes unnecessary rerendering and animating)

normal.not.fixed.mov

PR

I am creating a PR for this myself, the fix seems pretty straightforward at first glance.
@ixam1 ixam1 added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 17, 2023
@wangela
Copy link
Member

wangela commented Nov 17, 2023

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@ixam1 Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@ixam1 ixam1 linked a pull request Nov 17, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent unnecessary rerendering of clusters when nothing has changed ixam1/js-markerclusterer
2 participants
@wangela @ixam1