fix: prevent unnecessary rerendering of clusters when nothing has changed #802
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks @ixam1 for offering this fix; please make sure to sign the CLA so that doesn't block merging of your pull request. |
|
This doesn't quite sit right with me. It seems to work, but I feel like checking the number of clusters as a proxy for "has anything changed" isn't accurate enough. Why don't we fix the "changed" flag being returned instead, since obviously the algorithms don't properly signal changes to the markerclusterer? |
This PR fixes the unnecessary rerendering of clusters when nothing has changed.
Fixes #801 馃
The fix is pretty simple, just compare the amount of clusters from before and after and if its the same -> dont render.
Correct me if I am wrong I am no expert in the algorithms used here, but this should cover all cases right? Since whenever clusters are changing they will either combine or decluster and in either way the amount of clusters will decrease or increase, so this simple check should work.
fractional.not.fixed.mov
fractional.fixed.mov
normal.not.fixed.mov
normal.fixed.mov
fractional.no.animation.not.fixed.mov