Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-release: provide published package alongside source code with releases on github #714

Open
gemal opened this issue Aug 2, 2023 · 4 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gemal
Copy link

gemal commented Aug 2, 2023

Thanks for stopping by to let us know something could be better!

Is your feature request related to a problem? Please describe.
would be super nice to have a "dist" folder where generated files were in the releases

@gemal gemal added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 2, 2023
@wangela
Copy link
Member

wangela commented Aug 2, 2023

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@gemal Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@usefulthink
Copy link
Contributor

Not sure I'm understanding what you are asking for. We do publish the ./dist folder with all releases (see https://www.npmjs.com/package/@googlemaps/markerclusterer?activeTab=code). Or where did you expect to find them?

@usefulthink usefulthink added needs more info This issue needs more information from the customer to proceed. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. labels Sep 29, 2023
@gemal
Copy link
Author

gemal commented Sep 29, 2023

I was refering to this file: https://github.com/googlemaps/js-markerclusterer/archive/refs/tags/v2.5.0.zip
the one that is available for each release
That does not contain the dist folder

@usefulthink
Copy link
Contributor

Thanks for clarifying. Those are snapshots of the GitHub repo for the release-tags, and as such don't contain the generated files. I'm not sure if it's possible to replace them with something else.

@usefulthink usefulthink changed the title Provide dist folder in releases semantic-release: provide published package alongside source code with releases on github Sep 29, 2023
@usefulthink usefulthink added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed needs more info This issue needs more information from the customer to proceed. labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants