Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Compile this library in strict mode #642

Open
vicb opened this issue May 24, 2023 · 1 comment
Open

[FR] Compile this library in strict mode #642

vicb opened this issue May 24, 2023 · 1 comment
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vicb
Copy link
Contributor

vicb commented May 24, 2023

There are a few typing issues in the code

i.e.

https://github.com/googlemaps/js-markerclusterer/blob/e8eecf49b1d1f59579f3316c705f2c131b796560/src/algorithms/grid.ts#LL49C1-L61C4

this.state = { zoom: null }; is not compatible with protected state: { zoom: number };

This lib should be compiled with { strict: true} in the tsconfig.json.

WDYT @amuramoto ?

(I could volunteer to help)

@vicb vicb added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 24, 2023
@amuramoto
Copy link
Member

Would love to see this happen

@usefulthink usefulthink added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants