Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deleteScript should be private #208

Open
jpoehnelt opened this issue Mar 16, 2021 · 2 comments
Open

deleteScript should be private #208

jpoehnelt opened this issue Mar 16, 2021 · 2 comments
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jpoehnelt
Copy link
Contributor

I am not aware of a valid use for deleteScript. It should be removed from the public class interface.
@jpoehnelt jpoehnelt added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Mar 16, 2021
@jpoehnelt jpoehnelt mentioned this issue Mar 16, 2021
Closed
@martijnmelchers
Copy link

I disagree, we use it to unload the script on language change and load it back in with a new language.

@chrisjshull
Copy link
Contributor

I disagree, we use it to unload the script on language change and load it back in with a new language.

FWIW, the API does not officially support doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisjshull @jpoehnelt @martijnmelchers