Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing type administrative_area_level_6 and administrative_area_level_7 #986

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Add missing type administrative_area_level_6 and administrative_area_level_7 #986

wants to merge 1 commit into from

Conversation

gpradhan27
Copy link

@gpradhan27 gpradhan27 commented May 14, 2024 •
edited

This PR adds the missing AddressComponentType administrative_area_level_6 and administrative_area_level_7 - the java doc comments for enum types were copied from https://developers.google.com/maps/documentation/geocoding/requests-geocoding , hope this is the correct one.

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #985 🦕

@gpradhan27
Copy link
Author

hi @wangela could you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown type for enum com.google.maps.model.AddressComponentType: 'administrative_area_level_7'
1 participant
@gpradhan27