Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery/storage/managedwriter: TestIntegration_MingledContexts failed #10128

Closed
flaky-bot bot opened this issue May 7, 2024 · 1 comment · Fixed by #10169
Closed

bigquery/storage/managedwriter: TestIntegration_MingledContexts failed #10128

flaky-bot bot opened this issue May 7, 2024 · 1 comment · Fixed by #10169
Assignees
@shollyman
Labels
api: bigquery Issues related to the BigQuery API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 7, 2024

Note: #9819 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 37220bd
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 7, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label May 7, 2024
@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented May 7, 2024

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (37220bd), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label May 7, 2024
shollyman added a commit to shollyman/google-cloud-go that referenced this issue May 14, 2024
@shollyman
fix(bigquery/storage/managedwriter): faster context failure on send
e224f77 
This is a minor PR that accelerates the failure loop for context
expiration cases.  Previously, the connection abstraction would
deal with expired context on the receiver side, and this change
simply checks context before allowing a new append to succeed.

Tests already existed that exhibited this behavior, but were timing
dependent and masked the issue (the receiver would close the connection
fast enough).

Fixes: googleapis#10128
@shollyman shollyman mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the BigQuery API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bigquery/storage/managedwriter): faster context failure on send shollyman/google-cloud-go
1 participant
@shollyman