Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update automatic retries and Implement Retryable interface for token endpoint requests #366

Open
TimurSadykov opened this issue Feb 16, 2022 · 7 comments
Open

Update automatic retries and Implement Retryable interface for token endpoint requests #366

TimurSadykov opened this issue Feb 16, 2022 · 7 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@TimurSadykov
Copy link
Member

TimurSadykov commented Feb 16, 2022 •
edited

Currently, clients do not have a good way to distinguish retryable errors and implement custom retry strategies. Sometimes this causes infinite retries like here: googleads/google-ads-ruby#246
Please consider fixing with a priority since its affecting services like Ads.

In addition, the implementation of automatic retries requires some changes to follow Auth service guidelines.

More details in the doc: go/auth-correct-retry
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 17, 2022
@bajajneha27 bajajneha27 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 28, 2022
@mcloonan mcloonan mentioned this issue Apr 20, 2022
Closed
@diegosaul402
Copy link

Any updates on this? I'm also facing this error.

@tmck-code
Copy link

Also seeing this error 🤚

@jheathco
Copy link

Infinite loop here as well

@simonknoll
Copy link

simonknoll commented Aug 24, 2022 •
edited

Also having the infinite loop issue googleads/google-ads-ruby#246

@zerobearing2
Copy link

Infinite loop here as well

@OliverGilan
Copy link

I am also seeing this error

@TimurSadykov
Copy link
Member Author

@viacheslav-rostovtsev was this effectively fixed with googleads/google-ads-ruby#246 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@zerobearing2 @jheathco @simonknoll @TimurSadykov @bajajneha27 @tmck-code @OliverGilan @diegosaul402 @yoshi-automation