Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: cgroups setup causes unrecoverable errors #4685

Open
dvyukov opened this issue Apr 15, 2024 · 0 comments
Open

executor: cgroups setup causes unrecoverable errors #4685

dvyukov opened this issue Apr 15, 2024 · 0 comments

Comments

@dvyukov
Copy link
Collaborator

dvyukov commented Apr 15, 2024

I don't have full proof, but looking at spikes of SYZFATAL errors I think the following can happen.
We create cgroups of the for "/syzcgroup/*/syz{{PROCID}}" and then use this cgroup for all tests for PROCID, we don't create per-test cgroups. So if a test messes with cgroup settings, e.g. restricts memory to a very low value, all subsequent tests for the same PROCID will fail. Even if executor is restarted.
We either should create per-test cgroups, or at least per loop process cgropus, so that restarting executor fixes things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant