New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re2 dropped support for VS 2017. Need to keep re2 dependency pinned #1338

Open

dneto0 opened this issue Jun 23, 2023 · 0 comments

Assignees

Labels

version/release

Collaborator

dneto0 commented Jun 23, 2023

RE2 will not compile with a compiler older than VS2019.
See https://github.com/google/re2/blob/7c5e396af825562ec8321fdbf2f1cf276b26e3ae/CMakeLists.txt#L39

So the DEPS needs to pin the re2 dependency to a commit before May 2023. At least until we can increase the minimum compiler to VS2019.

dneto0 self-assigned this

dneto0 added the version/release label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment