Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for combinedImageSamplers? #1310

Open
Makogan opened this issue Mar 7, 2023 · 1 comment
Open

Support for combinedImageSamplers? #1310

Makogan opened this issue Mar 7, 2023 · 1 comment

Comments

@Makogan
Copy link

Makogan commented Mar 7, 2023

The microsoft compiler supports a special atribute for compatibility with glsl:
https://github.com/microsoft/DirectXShaderCompiler/wiki/Vulkan-combined-image-sampler-type

However declaring this in an hlsl shader:

[[vk::combinedImageSampler]]
Texture2D<float4> textures[3] : register(t1);

And compiling with shaderc results in the error:
examples/02_skinned_mesh/test.frag.hlsl:1: warning: 'combinedImageSampler' : unrecognized attribute

It would be a nice addition to shaderc I think. I would certainly find it very useful.

@Makogan Makogan changed the title Support for combinedImaeSamplers? Support for combinedImageSamplers? Mar 7, 2023
@dneto0
Copy link
Collaborator

dneto0 commented Mar 20, 2023

This should be filed upstream in Glslang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants