Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow users to override GOVERSION #850

Merged
merged 5 commits into from Mar 11, 2024
Merged

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Mar 8, 2024

fixes #848.
Allow users to specify a GOVERSION other than the one in go.mod .

Usage: in toml, GoVersionOverride = "1.21.0"

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (b28c1c8) to head (57af90d).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   59.78%   60.96%   +1.17%     
==========================================
  Files         136      144       +8     
  Lines       11268    11762     +494     
==========================================
+ Hits         6737     7171     +434     
- Misses       4102     4119      +17     
- Partials      429      472      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also add a snapshot test for this? (just a folder under cmd/osv-scanner/fixtures filled with a go.mod file and a osv-scanner config file should be enough)

pkg/osvscanner/osvscanner.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hogo6002 hogo6002 merged commit 666bfc1 into google:main Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow GOVERSION to be overridden
5 participants