Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_modules artifact extraction #791

Open
another-rex opened this issue Feb 7, 2024 · 4 comments
Open

Add node_modules artifact extraction #791

another-rex opened this issue Feb 7, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@another-rex
Copy link
Collaborator

Add node_modules artifact extraction ability

@another-rex another-rex added the enhancement New feature or request label Feb 7, 2024
@G-Rath
Copy link
Collaborator

G-Rath commented Feb 27, 2024

@another-rex could you expand a bit on the initial implementation for this? If I recall correctly when we last spoke currently we want to do this using the node_module/.package-lock.json file since the interfaces don't currently support walking directories (which also blocks #790 unless Python has a similar file?)

And should this only happen in containers?

@another-rex
Copy link
Collaborator Author

f I recall correctly when we last spoke currently we want to do this using the node_module/.package-lock.json file since the interfaces don't currently support walking directories (which also blocks #790 unless Python has a similar file?)

Yep, let's use node_modules/.package-lock.json until we update the extractor interface.

And should this only happen in containers?

Yes, I think this just means we don't have an init function that runs registerExtractors()

@another-rex
Copy link
Collaborator Author

For #790, I think .egg-info is a single file (a zip file I believe)? I'm not sure though I haven't looked into it enough. It will prevent us iterating through site-packages / dist-packages folders though.

@G-Rath
Copy link
Collaborator

G-Rath commented Mar 18, 2024

Apparently I completely forgot to link #851 with this - that adds at least initial support for scanning some node_modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants