Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better pre-commit monitoring for MSan false positives #11941

Open
davidben opened this issue May 10, 2024 · 0 comments
Open

Better pre-commit monitoring for MSan false positives #11941

davidben opened this issue May 10, 2024 · 0 comments

Comments

@davidben
Copy link
Contributor

After the most recent round of MSan false positives (#11886), perhaps OSS-Fuzz could consider better pre-commit testing? For example:

Before every tooling update, run the fuzzers over the existing corpus, or at least a random sample of them. Collect the new bugs that would be filed and the bugs that would be closed. If there are a lot, someone from OSS-Fuzz should triage them and confirm that this is working as intended and there isn't something gone horribly wrong.

If triaging other projects things is tricky (pretty understandable), OSS-Fuzz could maintain a benchmark project containing fuzzers that are known to surface problems and not surface problems. Those could be used for pre-commit testing. In particular, there should be benchmark fuzzers that break if libc and libc++ are not correctly instrumented in MSan.

Then, just as well-run projects are expected to write regression tests when things break, OSS-Fuzz should add to this benchmark project whenever a false positive slips through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant