Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also check forbidden/unknown licenses for save, csv commands #108

Open
Bobgy opened this issue Feb 21, 2022 · 1 comment
Open

Also check forbidden/unknown licenses for save, csv commands #108

Bobgy opened this issue Feb 21, 2022 · 1 comment

Comments

@Bobgy
Copy link
Collaborator

Bobgy commented Feb 21, 2022

I think it doesn't make sense to successfully terminate save/csv commands when there are forbidden licenses.

Also, it'd be time wasting if we run the check command and save/csv command together, because with the current implementation, we will need to re-scan for all licenses again.

Proposal

Two options:

  • breaking change: let save/csv commands check license type as well and emit errors if any problems are found
  • backwards compatible: add a new flag like --exit_status or --check, and also do the check logic in other commands as well
@wlynch
Copy link
Contributor

wlynch commented Mar 1, 2022

I think the --check option makes the most sense here. We can keep the existing behavior (which seems useful as a standalone reporting tool).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants