Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setters to CSS union types #44

Open
pstockley opened this issue Apr 3, 2018 · 1 comment
Open

Add setters to CSS union types #44

pstockley opened this issue Apr 3, 2018 · 1 comment
Assignees

Comments

@pstockley
Copy link

Would it be possible to add setter methods to the CSS style properties that are represented by a Union type? For example, to set the padding property you can't do

someElement.style.setPadding("100px")

Where as for non union types you can do:

someElement.style.color ="red";

@jDramaix jDramaix self-assigned this Apr 13, 2018
@jDramaix
Copy link
Member

We have that logic for parameters method that take UnionType so it could make sense to have that for field.
My concern is that it could bring some confusion to end users for having getter/setter for some filed and not for all. If we go that road we should generate getter/setter for every field.
Note that I tried to generate getter and setter for every field but it introduces soveral issues like: conflict with exisiting method, JsOverlay method overriding,...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants