Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish JNI artefacts (including platform-dependent) #1060

Open
deshanxiao opened this issue Aug 10, 2023 · 7 comments
Open

Publish JNI artefacts (including platform-dependent) #1060

deshanxiao opened this issue Aug 10, 2023 · 7 comments

Comments

@deshanxiao
Copy link

Is it possible for us to support the java version of Brotli's encoder?

@eustas
Copy link
Collaborator

eustas commented Aug 10, 2023

Hello. Do you mean pure Java encoder?

@deshanxiao
Copy link
Author

Hi @eustas yes, I try to find java encoder in https://mvnrepository.com/artifact/org.brotli. But it seems that there is just a dec component.

@eustas
Copy link
Collaborator

eustas commented Aug 10, 2023

Unfortunately, we currently do not have pure Java encoder, but we do have plans to implement it. Generally speaking, C brotli as it is today is a collection of encoders which share some common code.

What quality range (fast, balanced, maximal density) is the primary target? Knowing that would allow us to focus on it first.

(Also I have a dream that a decent WASM runtime for JVM will arrive and it will allow easier porting of native code to Java libraries)

@deshanxiao
Copy link
Author

deshanxiao commented Aug 10, 2023

In fact, it can also be accpeted in the form of JNI if we could provide a offical jar packages and support enough system architecture (like aarch64).

Since there is no official java encoder support, we have to use a library such as https://github.com/hyperxpro/Brotli4j

What quality range (fast, balanced, maximal density) is the primary target? Knowing that would allow us to focus on it first.

It might be better if users can adjust these parameters according to their needs.

@eustas
Copy link
Collaborator

eustas commented Aug 10, 2023

Agree. We could do that much faster (and encoder will be much more performant).
I'll update issue title then.

For pure java encoder there is #405

@eustas eustas changed the title Provide an encoder implementation in Java Publish JNI artefacts (including platform-dependent) Aug 10, 2023
@deshanxiao
Copy link
Author

Thank you @eustas! If you don't mind please let me know if there is any progress.

@deshanxiao
Copy link
Author

Hi @eustas Do we have any plans to implement this feature for Java users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants