-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine/ Improve Readability and Maintainability of Data Purge Function (purge()) #2529
engine/ Improve Readability and Maintainability of Data Purge Function (purge()) #2529
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2528
Description
Refactor purge() function for improved readability and maintainability
This pull request refactors the
purge
function to enhance code clarity and maintainability. The current implementation utilizes nested conditionals for resource presence, local changes, and force purge checks. This refactoring separates these concerns for improved readability.Changes:
localChanges.isNotEmpty()
) and theforcePurge
flag within a single condition.These improvements promote better code understanding and maintainability for future developers.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.