-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Readability and Maintainability of Data Purge Function (purge()) #2528
Labels
Comments
itstanany
added a commit
to itstanany/android-fhir
that referenced
this issue
Apr 28, 2024
itstanany
added a commit
to itstanany/android-fhir
that referenced
this issue
Apr 28, 2024
7 tasks
Thanks @itstanany. This looks good to me! |
itstanany
added a commit
to itstanany/android-fhir
that referenced
this issue
May 12, 2024
itstanany
added a commit
to itstanany/android-fhir
that referenced
this issue
Jun 1, 2024
jingtang10
added a commit
to itstanany/android-fhir
that referenced
this issue
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Issue
This issue proposes a refactoring of the
purge
function within the engine module for improved code readability and maintainability. The current implementation checks for resource presence, local changes, and force purge flag within nested conditional statements, potentially leading to less readable and maintainable code.Suggested Changes:
The proposed refactor aims to achieve the same functionality with improved clarity by:
localChanges.isNotEmpty()
) and theforcePurge
flag within a single condition.Benefits:
Attached Code Snippets:
Include the current and proposed code snippets within the issue description for easy reference:
Current Code:
Proposed Code:
This approach provides a clear and concise issue description for the Android FHIR repository, promoting collaboration and potential code improvement.
Would you like to work on the issue?
Yes 🚀
The text was updated successfully, but these errors were encountered: