Return unique include and revInclude resources per search filter match. #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJ1998
reviewed
May 16, 2024
MJ1998
reviewed
May 21, 2024
engine/src/main/java/com/google/android/fhir/search/MoreSearch.kt
Outdated
Show resolved
Hide resolved
engine/src/androidTest/java/com/google/android/fhir/db/impl/DatabaseImplTest.kt
Show resolved
Hide resolved
jingtang10
requested changes
May 31, 2024
| @@ -2369,7 +2369,7 @@ class SearchTest { | |||
| .isEqualTo( | |||
| """ | |||
| SELECT * FROM ( | |||
| SELECT rie.index_name, rie.resourceUuid, re.serializedResource | |||
| SELECT DISTINCT rie.index_name, rie.resourceUuid, re.serializedResource | |||
There was a problem hiding this comment.
discussed with aditya - i'm worried about what it means to be sorting by a field that is repeated.... for example if you have a patient with two given names aaron and charlie, and another one with two given names barry and david, then what order should this query actually produce, if it's deterministic at all?
do we know that the ordering here is perserved somehow (i.e. we take the first value)?
Comment on lines
+4092
to
+4093
| // A person has multiple first names. Searching a group including Patient sorted by | ||
| // Patient.GIVEN should return single copy of of the Patient resource. |
There was a problem hiding this comment.
can you explain a little bit more that the dupliatees of record are generated by the join sql statement for the sorting. and probably link to the issue as well.
jingtang10
requested changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2512
Description
meta.lastUpdated, use that for index value.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.