Fhir engine converts List resource to Binary resource while syncing

[mansikalraa]

Describe the bug
A clear and concise description of what the bug is.

@jingtang10 @aditya-07
Fhir engine converts List resource to Binary resource while syncing. The change log in LocalChangeEntity is correct, But while uploading the resourceType is converted to binary and the data is something entirely different.

  {
      "fullUrl": "List/569",
      "resource": {
        "resourceType": "Binary",
        "contentType": "application/json-patch+json",
        "data": "W3sib3AiOiJyZXBsYWNlIiwicGF0aCI6IlwvZGF0ZSIsInZhbHVlIjoiMjAyNC0wMy0wOFQwNTowNzozMy40NDVaIn0seyJvcCI6InJlcGxhY2UiLCJwYXRoIjoiXC9lbnRyeVwvMlwvZGF0ZSIsInZhbHVlIjoiMjAyNC0wMy0wOFQwNTowNjo0OSswMDowMCJ9LHsib3AiOiJhZGQiLCJwYXRoIjoiXC9lbnRyeVwvMlwvaXRlbVwvcmVmZXJlbmNlIiwidmFsdWUiOiJRdWVzdGlvbm5haXJlUmVzcG9uc2VcL2ZhNjUzYmNmLTkxMjctNDg1Mi1iZTc5LTU2M2E2N2NlODllMSJ9LHsib3AiOiJhZGQiLCJwYXRoIjoiXC9lbnRyeVwvMlwvaXRlbVwvdHlwZSIsInZhbHVlIjoiUXVlc3Rpb25uYWlyZVJlc3BvbnNlIn0seyJvcCI6InJlcGxhY2UiLCJwYXRoIjoiXC9lbnRyeVwvMlwvZmxhZ1wvY29kaW5nXC8wXC9jb2RlIiwidmFsdWUiOiIwMyJ9LHsib3AiOiJyZXBsYWNlIiwicGF0aCI6IlwvZW50cnlcLzJcL2ZsYWdcL2NvZGluZ1wvMFwvZGlzcGxheSIsInZhbHVlIjoiY29tcGxldGVkIn0seyJvcCI6ImFkZCIsInBhdGgiOiJcL2VudHJ5XC8tIiwidmFsdWUiOnsiZmxhZyI6eyJjb2RpbmciOlt7InN5c3RlbSI6InVybjpvaWQ6MS4yLjM2LjEuMjAwMS4xMDAxLjEwMS4xMDQuMTY1OTIiLCJjb2RlIjoiMDEiLCJkaXNwbGF5IjoicGVuZGluZyJ9XX0sImRhdGUiOiIyMDI0LTAzLTA4VDA1OjA3OjEwKzAwOjAwIiwiaXRlbSI6eyJkaXNwbGF5IjoiZGV2aWNlIGlzc3VlIn19fSx7Im9wIjoicmVwbGFjZSIsInBhdGgiOiJcL2VudHJ5XC8zXC9kYXRlIiwidmFsdWUiOiIyMDI0LTAzLTA4VDA1OjA3OjEwKzAwOjAwIn0seyJvcCI6ImFkZCIsInBhdGgiOiJcL2VudHJ5XC8zXC9pdGVtXC9yZWZlcmVuY2UiLCJ2YWx1ZSI6IkVuY291bnRlclwvYjlhMWI3MTktNTJkMC00Y2VmLWFjNTYtYjdjZWNiMDVkNjA4In0seyJvcCI6InJlcGxhY2UiLCJwYXRoIjoiXC9lbnRyeVwvM1wvZmxhZ1wvY29kaW5nXC8wXC9jb2RlIiwidmFsdWUiOiIwMyJ9LHsib3AiOiJyZXBsYWNlIiwicGF0aCI6IlwvZW50cnlcLzNcL2ZsYWdcL2NvZGluZ1wvMFwvZGlzcGxheSIsInZhbHVlIjoiY29tcGxldGVkIn0seyJvcCI6InJlcGxhY2UiLCJwYXRoIjoiXC9lbnRyeVwvNFwvZGF0ZSIsInZhbHVlIjoiMjAyNC0wMy0wOFQwNTowNzozMyswMDowMCJ9LHsib3AiOiJyZXBsYWNlIiwicGF0aCI6IlwvZW50cnlcLzRcL2ZsYWdcL2NvZGluZ1wvMFwvY29kZSIsInZhbHVlIjoiMDMifSx7Im9wIjoicmVwbGFjZSIsInBhdGgiOiJcL2VudHJ5XC80XC9mbGFnXC9jb2RpbmdcLzBcL2Rpc3BsYXkiLCJ2YWx1ZSI6ImNvbXBsZXRlZCJ9XQ=="
      },
      "request": {
        "method": "PATCH",
        "url": "List/569",
        "ifMatch": "W/\"2\""
      }
    }

Due to this the syncing process fails entirely, which is causing us the loss of important data.

Component
Core library (Fhir engine)

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

The resourceType of List resource should not be changed to Binary, and the syncing process should work correctly.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

• Device: [e.g. Pixel4a emulator] OPPO A15s
• Android version: [e.g. Settings -> About phone -> Android version] 10
• Build number: [e.g. Settings -> About phone -> Build number]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

[santosh-pingle]

does it work for other resource type e.g Bundle, Single Resource Patch?

[aditya-07]

@mansikalraa Can you provide the data (maybe the LocalChangeEntity of List/569) for us to debug the issue that the Binary data is completely different ?

The PATCH's data is basically Base64 encoding of the LocalChangeEntity.payload and incase List/569 has more than one LocalChangeEntity (multiple changes made to the list resource on device before sync), then all of these LocalChangeEntity are merged (as per Json Patch Merge) to create a single LocalChangeEntity.payload and sent up in a PATCH to the server.