Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider make flax an optional dependency #780

Closed
jjyyxx opened this issue May 15, 2024 · 1 comment
Closed

Consider make flax an optional dependency #780

jjyyxx opened this issue May 15, 2024 · 1 comment

Comments

@jjyyxx
Copy link
Contributor

jjyyxx commented May 15, 2024

It seems that the sole purpose of the flax dependency is to support conversion between haiku and flax, but flax's dependencies are considerably heavier compared to the rest of haiku. I think it is a good idea to make flax an extra dependency, and avoid importing haiku.experimental.flax eagerly.

@tomhennigan
Copy link
Collaborator

Thanks for letting us know! I'll take a look into whether we can do this for the next release.

copybara-service bot pushed a commit that referenced this issue May 21, 2024
Fixes #780.

PiperOrigin-RevId: 635381166
copybara-service bot pushed a commit that referenced this issue May 22, 2024
Fixes #780.

PiperOrigin-RevId: 635381166
copybara-service bot pushed a commit that referenced this issue May 22, 2024
Fixes #780.

PiperOrigin-RevId: 635381166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants