Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need to add a language list menu #2044

Open
zoumingzhe opened this issue Apr 17, 2024 · 4 comments
Open

we need to add a language list menu #2044

zoumingzhe opened this issue Apr 17, 2024 · 4 comments

Comments

@zoumingzhe
Copy link
Contributor

I wonder if we need to add a language list menu so that users can switch the display language instead of forcing it to be specified in the configuration.

This might make a lot of sense. First, we can preview the localization effect more quickly. Secondly, services based on gollum wiki can serve different regions.

@benjaminwil
Copy link
Member

I think this sounds great.

This localization would only effect the UI text, though. Right now there is no way to easily localize wiki page content. (i.e. Having both an English and a Chinese version of Home.md.)

So I think we should ensure that this list menu makes that clear somehow and doesn't confuse or disappoint end users.

@dometto
Copy link
Member

dometto commented Apr 17, 2024

Great idea @zoumingzhe!

And good point @benjaminwil. There could at least be a tooltip explaining the function of the language menu (itself localised of course ;-)).

@zoumingzhe
Copy link
Contributor Author

This localization would only effect the UI text, though. Right now there is no way to easily localize wiki page content. (i.e. Having both an English and a Chinese version of Home.md.)

I think Gollum does not need to localize wiki page content.

Usually, if a page has multiple language versions, they should be stored in different folders (such as wiki. example. com/en, wiki. example. com/cn). If the UI can switch with base_path, it would be very nice.

@dometto
Copy link
Member

dometto commented Apr 18, 2024

Usually, if a page has multiple language versions, they should be stored in different folders (such as wiki. example. com/en, wiki. example. com/cn). If the UI can switch with base_path, it would be very nice.

I think a first good milestone would be to have localisation for the UI. Localisation of wiki content is a nice idea but more complicated. Perhaps something like that could also be implemented using a Macro (checking if localisation is requested, and if a page in the requested language exist, the including it, for instance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants