Symlink page edit editing the symlink instead of target + leaves tree with unstaged changes

[douwedb]

Describe the bug
When using gollum to navigate to a symlink page (eg link-page that links to target-page) and edit it frow the webui it commits the changes directly to the link-page and removes the symlink. But after the commit the changes are applied to the target-page and the link is recreated, but these things are not commited.

To Reproduce
Steps to reproduce the behavior:

1. Have a wiki with symlink link-page to target-page
2. navigate to link-page on the webui
3. edit the link-page and save
4. git log shows the changes directly on link-page
5. git status shows the unstaged changes to target-page and the recreated link

Expected behavior
Leave the link intact and apply the changes directly to the target-page.

Screenshots
N/A

Environment Info

docker container: gollumwiki/gollum:v5.3.0
Gollum 5.3.0

[bartkamphorst]

Thanks for the report @douwedb . @dometto and I weren't able to reproduce step 5, neither on 5.3.0, nor on master. However, we can confirm that the symlink was overwritten on edit, which does constitute a bug.

We'll look into a fix for this, probably by ensuring that the symlink status is preserved on edit (in gollum) so that the write_page call (which is handled in gollum-lib) will get the path to the target page (instead of the path to the link page, as is currently the case).