Replies: 1 comment 1 reply
-
With the caveat being that I have never used view components before, I think that if we were to continue to use Primer, I have experience writing React. While I don't hate it, I don't think it makes sense for Gollum to pivot to using React just for Primer. This pivot would be a lot of work, I think. That said, migrating to any CSS-first frontend framework would likely be a lot of work 😪 Thanks for opening this discussion and mentioning me. I will think more on this. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
It seems like the
primer/css
library is being abandoned by GitHub:https://primer.style/design/deprecated-components/select-menu/css/
Alternatives are
primer/react
andprimer/view-components
. However, neither seems to be very easy to implement in Gollum. ViewComponent seems to be tied very deeply to Rails, whereas usingreact
would, I think, require substantial changes to gollum's architecture.Short term, I propose that we just keep using
primer/css
, and improve the UI as well as we can within that framework. Longer term, there may be some things we simply cannot achieve usingprimer/css
(such as Dialogs?). To reduce reliance on our JS (for e.g. the dialog), we might then have to migrate to a different CSS framework.@benjaminwil: do you have any ideas about this? Do you agree that using
primer/react
orprimer/view-components
is not feasible? Longer term, would moving to an alternative framework like tailwind be an option?Beta Was this translation helpful? Give feedback.
All reactions