Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-go: changing testFlag setting requires restart #3291

Open
pjweinb opened this issue Mar 29, 2024 · 3 comments
Open

vscode-go: changing testFlag setting requires restart #3291

pjweinb opened this issue Mar 29, 2024 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@pjweinb
Copy link

pjweinb commented Mar 29, 2024

Go version

go version go1.23-20240317-RC00 cl/616607620 +0a6f05e30f X:fieldtrack,boringcrypto linux/amd64

Output of go env in your module/workspace:

doesn't matter

What did you do?

in settings.json, i changed the value of go.TestFlags

What did you see happen?

clicking on the "run test | debug test" line above the function definition no longer works, requiring gopls to be restarted (Developer: reload window)

What did you expect to see?

At least a warning that the window needed to be reloaded. It would be even better if the window did not have to be reloaded.

@pjweinb
Copy link
Author

pjweinb commented Mar 29, 2024

This doesn't always happen, and I'm not sure when it does or doesn't.

@seankhliao seankhliao transferred this issue from golang/go Mar 29, 2024
@gopherbot gopherbot added this to the Untriaged milestone Mar 29, 2024
@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 29, 2024
@findleyr
Copy link
Contributor

CC @hyangah

@findleyr
Copy link
Contributor

At the very least, this should be deterministic, and generally the expectation is that setting changes take effect immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants