Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart immutability implementation missing #342

Open
miloslavkrisko opened this issue Jun 22, 2022 · 2 comments
Open

Chart immutability implementation missing #342

miloslavkrisko opened this issue Jun 22, 2022 · 2 comments
Assignees

Comments

@miloslavkrisko
Copy link

This is more like an improvement request then an issue.
Currently on Helm chart section there is no way how to implement an Chart immutability the same way as it is possible for the repositories.

Use Case is following:
Let's say you have an application with Helm chart version 1.4.0 and app Version 1.4.0.
The developer prepares the changes for 1.4.1 but accidently push it without version increase as the version is taken from the package.json to have it exactly mapped.

In this case it will happen that the version 1.4.0 is no longer true and get's overwritten. (I know it does not cause an issue untill helm repo update command is run, but still it is not a safe approach.

@miloslavkrisko miloslavkrisko changed the title Chart immutability Chart immutability implementation missing Jun 22, 2022
@OrlinVasilev OrlinVasilev self-assigned this Jul 26, 2022
@OrlinVasilev
Copy link
Member

Hi @miloslavkrisko - I suppose that's more issue to be resolved on the chart-museum side ?

@miloslavkrisko
Copy link
Author

miloslavkrisko commented Aug 1, 2022

Hi @OrlinVasilev tbh i wasn't 100% if that's think which should be resolved on chart-museum side or within harbor side.

As i can imagine that on chart-museum there can be some variable or something which could enable this behaviour, but at the same time it can be part of harbor where if the toggle is setup for the project then the script would call somethink like:
helm search repo | grep | grep | wc -l != (0/1) -> i am not sure if that will return 0 or 1 as counted the command itself and based on that it would throw an error.

But if you think it is more on chart-museum side i can try to create a request on their end :)

Also sorry for late reply, but i was on vacation in nature with no laptop to disconnect from modern world :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants