Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent group_type #353

Open
guyguy333 opened this issue Jul 29, 2023 · 2 comments
Open

Consistent group_type #353

guyguy333 opened this issue Jul 29, 2023 · 2 comments

Comments

@guyguy333
Copy link

Is your feature request related to a problem? Please describe.

Currently, group_type field can be either an integer (harbor_group resource) or a string value (harbor_project_member_group). We cannot easily reuse value from one resource to another.

Describe the solution you'd like

Use a consistent field type for group_type

Describe alternatives you've considered

None

Additional context

@naitmare01
Copy link
Contributor

What makes more sense, using integers as stated in the API or using the custom strings implemented in this provider?

I think it makes more sense to stick to the API and drop the custom strings. This makes it more clear and less error prone and more future proof.

Git blame on the affected rows:
https://github.com/goharbor/terraform-provider-harbor/blame/7453ba31f2174e0e4c3b4e73b3ae23b18204f3d5/client/project_members.go#L33

@dmakeienko
Copy link

Same for project_id in resource harbor_project_member_user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants